-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theming - Move ThemeProvider updates into useEffect #1681
Labels
Comments
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Dec 11, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Dec 11, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Dec 11, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Dec 11, 2023
bmingles
added a commit
to bmingles/web-client-ui
that referenced
this issue
Dec 13, 2023
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Updates to theme variables happen as a result of selected theme changes in ThemeProvider. The current implementation requires consumers to respond to changes in an effect to ensure variables have updated before parsing. We should encapsulate this in the ThemeProvider so that consumers don't have to handle it.
The text was updated successfully, but these errors were encountered: