Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming - Move ThemeProvider updates into useEffect #1681

Closed
bmingles opened this issue Dec 11, 2023 · 1 comment · Fixed by #1682
Closed

Theming - Move ThemeProvider updates into useEffect #1681

bmingles opened this issue Dec 11, 2023 · 1 comment · Fixed by #1682
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

Updates to theme variables happen as a result of selected theme changes in ThemeProvider. The current implementation requires consumers to respond to changes in an effect to ensure variables have updated before parsing. We should encapsulate this in the ThemeProvider so that consumers don't have to handle it.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Dec 11, 2023
@bmingles bmingles self-assigned this Dec 11, 2023
@bmingles bmingles added web-client-ui and removed triage Issue requires triage labels Dec 11, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 11, 2023
@bmingles
Split out conditional rendering
3ab65c8 
deephaven#1681
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 11, 2023
@bmingles
Split out conditional rendering
b689d43 
deephaven#1681
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 11, 2023
@bmingles
Fixed animation for DHE
d88ba9b 
deephaven#1681
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 11, 2023
@bmingles
Fixed missing gaps in some loading spinners
f793916 
deephaven#1681
bmingles added a commit to bmingles/web-client-ui that referenced this issue Dec 13, 2023
@bmingles
Removed null checks from providers
ae25ea6 
deephaven#1681
@bmingles bmingles linked a pull request Jan 2, 2024 that will close this issue
feat: Theming - Moved ThemeProvider updates into effect #1682
Merged
@bmingles bmingles mentioned this issue Jan 2, 2024
Merged
@bmingles
Copy link
Contributor Author

bmingles commented Jan 2, 2024

Merged

@bmingles bmingles closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Theming - Moved ThemeProvider updates into effect bmingles/web-client-ui
1 participant
@bmingles