Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed chart e2e test changing daily #1652

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Nov 17, 2023

Fixed an issue where chart dates change every day and break e2e tests.

#1634

@bmingles bmingles linked an issue Nov 17, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a2ef056) 46.65% compared to head (9db5665) 46.65%.

Files Patch % Lines
packages/chart/src/MockChartModel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1652   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files         593      593           
  Lines       36467    36467           
  Branches     9135     9135           
=======================================
  Hits        17014    17014           
  Misses      19401    19401           
  Partials       52       52           
Flag Coverage Δ
unit 46.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit f9f62db into deephaven:main Nov 17, 2023
6 checks passed
@bmingles bmingles deleted the 1634-fix-random-dates branch November 17, 2023 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming - Inline svgs need to support dynamic css prop colors
2 participants