Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Isolate Styleguide snapshots #1649

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

bmingles
Copy link
Contributor

I realized that snapshot tests for Styleguide were a bit brittle in that changes to a section in the Styleguide can cause subtle pixel shifts in snapshots of other sections. The snapshot tests now hide all sections not being tested to ensure they don't impact one another

@bmingles bmingles marked this pull request as ready for review November 16, 2023 18:21
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (561ff22) 46.65% compared to head (916a34f) 46.65%.

Files Patch % Lines
packages/code-studio/src/styleguide/StyleGuide.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files         593      593           
  Lines       36464    36467    +3     
  Branches     9133     9135    +2     
=======================================
+ Hits        17012    17014    +2     
- Misses      19400    19401    +1     
  Partials       52       52           
Flag Coverage Δ
unit 46.65% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit a2ef056 into deephaven:main Nov 17, 2023
5 checks passed
@bmingles bmingles deleted the 1634-fix-snapshots branch November 17, 2023 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants