Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize and centralize plugin types and configs #1454

Closed
Tracked by #1435
mattrunyon opened this issue Aug 21, 2023 · 0 comments · Fixed by #1456
Closed
Tracked by #1435

Normalize and centralize plugin types and configs #1454

mattrunyon opened this issue Aug 21, 2023 · 0 comments · Fixed by #1456
Assignees
@mattrunyon

Comments

@mattrunyon
Copy link
Collaborator

mattrunyon commented Aug 21, 2023 •
edited
Loading

Change plugins to expect a default exported object (or function if there's anything we think should be available at runtime to the config) containing things like component, supportedTypes, etc. Add TS types for the different plugin config types
@mattrunyon mattrunyon mentioned this issue Aug 21, 2023
Open
12 tasks
@mattrunyon mattrunyon changed the title Change plugins to expect a default exported object (or function if there's anything we think should be available at runtime to the config) containing things like component, supportedTypes, etc. Add TS types for the different plugin config types Normalize and centralize plugin types and configs Aug 21, 2023
@mattrunyon mattrunyon mentioned this issue Aug 22, 2023
Merged
@mattrunyon mattrunyon self-assigned this Aug 23, 2023
mattrunyon added a commit that referenced this issue Sep 8, 2023
@mattrunyon
feat: Consolidate and normalize plugin types (#1456)
43a782d 
Fixes #1454. Needs #1451

Still some cleanup that could be done around `DashboardPlugin`. I think
instead of static metadata on the component (`displayName` is ok since
it's part of React) those items should probably be part of the config
object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Consolidate and normalize plugin types mattrunyon/web-client-ui
1 participant
@mattrunyon