-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use user permissions for iframes instead of query parameters #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for it as well - Updated the embed readmes to link to Application mode correctly
- Now after the user has completed authentication, the user context is also bootstrapped - Wired up in embed-grid, and got rid of the canCopy/canDownloadCsv query parameters
Codecov Report
@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
+ Coverage 45.59% 45.70% +0.11%
==========================================
Files 506 511 +5
Lines 34997 35061 +64
Branches 8748 8763 +15
==========================================
+ Hits 15956 16026 +70
+ Misses 18990 18984 -6
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- Not sure why I was
mattrunyon
requested changes
Jul 6, 2023
- Remove Enterprise permissions from the community user permissions - Clean up how we retrieved a boolean value in tests - Fix error message
mattrunyon
reviewed
Jul 7, 2023
mattrunyon
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by setting the following in the dh-defaults.prop and verified the functionality matched with what I set: