Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some table features are shown even though they do not work correctly #136

Closed
mofojed opened this issue Jul 29, 2021 · 0 comments · Fixed by #137
Closed

Some table features are shown even though they do not work correctly #136

mofojed opened this issue Jul 29, 2021 · 0 comments · Fixed by #137
Assignees
@mofojed
Labels
bug Something isn't working web-client-ui
Milestone
July 2021

Comments

@mofojed
Copy link
Member

mofojed commented Jul 29, 2021

See deephaven/deephaven-core#37 and deephaven/deephaven-core#697. These options are shown even though they are not enabled on the server.

Make iris-grid customizable as to which options to shown, and only show options that are available.
@mofojed mofojed added bug Something isn't working web-client-ui labels Jul 29, 2021
@mofojed mofojed added this to the July 2021 milestone Jul 29, 2021
@mofojed mofojed self-assigned this Jul 29, 2021
mofojed added a commit to mofojed/deephaven-core that referenced this issue Jul 29, 2021
@mofojed
Comment out JsTable and JsTreeTable features that do not currently work.
5603cba 
- Related to deephaven#37 and deephaven#697, there is some table functionality that does not work yet.
- Comment out the methods that do not currently work (shouldn't have an API that doesn't work).
- UI checks for the presence of the method for whether to show the option or not. When they are added back, they should appear in the UI again. See deephaven/web-client-ui#136
This was referenced Jul 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
bug Something isn't working web-client-ui
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Disable aggregations if they're not enabled mofojed/web-client-ui
1 participant
@mofojed