fix: Catch errors when emitting events to prevent breaking entire layout #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jun 7, 2023
mofojed
commented
- Added a try/catch around all events that are emitted from Golden Layout
- Added @deephaven/log to golden layout so we can log the error
- Tested using the steps in Plotly - multiple series plots with color axis cause error when trying to move panel deephaven-plugins#40
- Fixes Golden Layout can break if a panel throws while dragging #1352
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 494 494
Lines 34423 34423
Branches 8587 8587
=======================================
Hits 15820 15820
Misses 18552 18552
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
mattrunyon
reviewed
Jun 7, 2023
mattrunyon
approved these changes
Jun 7, 2023
- Added a try/catch around all events that are emitted from Golden Layout - Added @deephaven/log to golden layout so we can log the error - Tested using the steps in https://github.com/deephaven/deephaven-js-plugins/issues/26 - Fixes deephaven#1352
- Couldn't get the ignore to work, not interested in rewiring it right now - The event still gets logged with the LogProxy and still appears in the exported support logs.
mofojed
force-pushed
the
1352-fix-layout-emit
branch
from
6088707
to
37f61f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.