Skip to content

Commit

Permalink
Just remove @deephaven/log from golden-layout
Browse files Browse the repository at this point in the history
- Couldn't get the ignore to work, not interested in rewiring it right now
- The event still gets logged with the LogProxy and still appears in the exported support logs.
  • Loading branch information
mofojed committed Jun 8, 2023
1 parent 9acb901 commit 37f61f2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 11 deletions.
2 changes: 0 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/golden-layout/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"type": "module",
"dependencies": {
"@deephaven/components": "file:../components",
"@deephaven/log": "file:../log",
"jquery": "^3.6.0"
},
"peerDependencies": {
Expand Down
8 changes: 2 additions & 6 deletions packages/golden-layout/src/utils/EventEmitter.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
import Log from '@deephaven/log';

const log = Log.module('EventEmitter');

/**
* A generic and very fast EventEmitter
* implementation. On top of emitting the
Expand Down Expand Up @@ -72,7 +68,7 @@ class EventEmitter {
try {
subs[i].fn.apply(ctx, args);
} catch (e) {
log.error('Error while emitting event:', e);
console.error('Error while emitting event:', e);
}
}
}
Expand All @@ -86,7 +82,7 @@ class EventEmitter {
try {
allEventSubs[i].fn.apply(ctx, args);
} catch (e) {
log.error('Error while emitting event to allEventSubs:', e);
console.error('Error while emitting event to allEventSubs:', e);
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions packages/golden-layout/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
"outDir": "dist/"
},
"include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.js", "src/**/*.jsx"],
"exclude": ["node_modules"],
"references": [{ "path": "../components" }, { "path": "../log" }]
"exclude": ["node_modules"]
}

0 comments on commit 37f61f2

Please sign in to comment.