Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright Snapshot Test Failing in Debug Mode #1327

Closed
ethanalvizo opened this issue May 29, 2023 · 0 comments · Fixed by #1328
Closed

Playwright Snapshot Test Failing in Debug Mode #1327

ethanalvizo opened this issue May 29, 2023 · 0 comments · Fixed by #1328
Assignees
@ethanalvizo
Labels
bug Something isn't working triage Issue requires triage

Comments

@ethanalvizo
Copy link
Contributor

Description

E2E tests fail when running in debug mode due to the element locator labels appearing in the snapshot comparison. They pass normally when not in debug mode because these labels are not rendered.

Steps to reproduce

  1. Run the following code in your terminal to run the e2e tests in debug mode:
    npm run e2e:headed -- ./tests/golden-layout.spec.ts
  2. Click the play button in the inspector to play through the tests

Expected results
image

Actual results
image

Additional details and attachments
The example above is for the golden-layout tests but the issue is not specific to it. Similar results can be achieved with other tests.

Versions

Engine Version: 0.24.2
Web UI Version: 0.40.1
Java Version: 17.0.7
Barrage Version: 0.5.0
OS: Mac
Browser: Edge
@ethanalvizo ethanalvizo added bug Something isn't working triage Issue requires triage labels May 29, 2023
@ethanalvizo ethanalvizo self-assigned this May 29, 2023
@ethanalvizo ethanalvizo mentioned this issue May 29, 2023
Merged
ethanalvizo added a commit that referenced this issue May 30, 2023
@ethanalvizo
fix: disable screenshot tests in debug mode (#1328)
cbe8f72 
Closes #1327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable screenshot tests in debug mode ethanalvizo/web-client-ui
1 participant
@ethanalvizo