Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestUtils - makeApiContextWrapper console error and mock proxy improvements #1311

Closed
bmingles opened this issue May 18, 2023 · 0 comments · Fixed by #1312
Closed

TestUtils - makeApiContextWrapper console error and mock proxy improvements #1311

bmingles opened this issue May 18, 2023 · 0 comments · Fixed by #1312
Assignees
@bmingles
Labels
enhancement New feature or request triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

  • makeApiContextWrapper currently shows a console error due to ApiContextWrapper not being wrapped in forwardRef
  • The proxy created by createMockProxy prints undefined when used in matchers. This could use some cleanup
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels May 18, 2023
@bmingles bmingles self-assigned this May 18, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 18, 2023
@bmingles
fix: makeApiContextWrapper and createMockProxy
b92c766 
deephaven#1311
@bmingles bmingles mentioned this issue May 18, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 18, 2023
@bmingles
Test coverage
0595cf0 
deephaven#1311
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 18, 2023
@bmingles
typo
241c389 
deephaven#1311
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 22, 2023
@bmingles
Split mock proxy into its own module
3fe7e92 
deephaven#1311
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 22, 2023
@bmingles
Fixed generic type on makeApiContextWrapper
10c5f3f 
deephaven#1311
bmingles added a commit to bmingles/web-client-ui that referenced this issue May 23, 2023
@bmingles
Added ref exclusion to MockProxy
a1b2bbb 
deephaven#1311
bmingles added a commit that referenced this issue May 23, 2023
@bmingles
fix: makeApiContextWrapper and createMockProxy (#1312)
d389963 
createMockProxy
- added `ref` to auto proxy exclusions
- now prints object properties instead of `undefined`
in jest matchers. 
- Proxied mock methods now include a mockName() call to
give clearer output

fixes #1311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: makeApiContextWrapper and createMockProxy bmingles/web-client-ui
1 participant
@bmingles