Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Revert "feat: Table rendering support for databars (#1212)" #1296

Merged
merged 1 commit into from
May 15, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented May 15, 2023

This reverts commit a17cc0e.

  • Noticed an issue when changing filters on a table with a string column which would cause null to be flashed in. Caused by the databar changes. We don't need the databars for this release so just reverting that change for now.

Table shows null to start

@mofojed mofojed requested a review from vbabich May 15, 2023 16:13
@mofojed mofojed self-assigned this May 15, 2023
@mofojed mofojed requested review from mattrunyon and removed request for vbabich May 15, 2023 16:13
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1296 (4b93683) into main (29ed459) will increase coverage by 0.39%.
The diff coverage is 50.71%.

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   45.49%   45.88%   +0.39%     
==========================================
  Files         504      492      -12     
  Lines       34826    34362     -464     
  Branches     8688     8567     -121     
==========================================
- Hits        15844    15768      -76     
+ Misses      18931    18543     -388     
  Partials       51       51              
Flag Coverage Δ
unit 45.88% <50.71%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/code-studio/src/styleguide/Grids.tsx 100.00% <ø> (ø)
packages/grid/src/GridColorUtils.ts 50.00% <ø> (+30.43%) ⬆️
packages/grid/src/GridMetricCalculator.ts 76.23% <0.00%> (+0.64%) ⬆️
packages/grid/src/GridModel.ts 38.29% <ø> (-2.52%) ⬇️
packages/grid/src/GridTheme.ts 100.00% <ø> (ø)
packages/grid/src/GridUtils.ts 61.06% <ø> (-1.16%) ⬇️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 46.59% <ø> (-1.19%) ⬇️
packages/iris-grid/src/IrisGridTheme.ts 100.00% <ø> (ø)
...rid/src/mousehandlers/IrisGridTokenMouseHandler.ts 4.76% <0.00%> (+0.53%) ⬆️
packages/iris-grid/src/IrisGridRenderer.ts 24.85% <22.31%> (-0.56%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

@mofojed mofojed changed the title Revert "feat: Table rendering support for databars (#1212)" revert: Revert "feat: Table rendering support for databars (#1212)" May 15, 2023
@vbabich vbabich merged commit a80c6fc into deephaven:main May 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants