Skip to content

Commit

Permalink
revert: Revert "feat: Table rendering support for databars (#1212)" (#…
Browse files Browse the repository at this point in the history
…1296)

This reverts commit a17cc0e.

- Noticed an issue when changing filters on a table with a string column
which would cause `null` to be flashed in. Caused by the databar
changes. We don't need the databars for this release so just reverting
that change for now.

![Table shows null to
start](https://github.com/deephaven/web-client-ui/assets/4505624/ced45b58-9caf-4f9e-8ffc-3218294db300)
  • Loading branch information
mofojed authored May 15, 2023
1 parent 29ed459 commit a80c6fc
Show file tree
Hide file tree
Showing 27 changed files with 668 additions and 2,081 deletions.
5 changes: 0 additions & 5 deletions packages/code-studio/src/styleguide/Grids.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import StaticExample from './grid-examples/StaticExample';
import QuadrillionExample from './grid-examples/QuadrillionExample';
import TreeExample from './grid-examples/TreeExample';
import AsyncExample from './grid-examples/AsyncExample';
import DataBarExample from './grid-examples/DataBarExample';

function Grids(): ReactElement {
const [irisGridModel] = useState(
Expand All @@ -35,10 +34,6 @@ function Grids(): ReactElement {
<div style={{ height: 200 }}>
<StaticExample />
</div>
<h2 className="ui-title">Data Bar</h2>
<div style={{ height: 500 }}>
<DataBarExample />
</div>
<h2 className="ui-title">Quadrillion rows and columns</h2>
<div style={{ height: 500, position: 'relative' }}>
<QuadrillionExample />
Expand Down
123 changes: 0 additions & 123 deletions packages/code-studio/src/styleguide/grid-examples/DataBarExample.tsx

This file was deleted.

104 changes: 0 additions & 104 deletions packages/grid/src/CellRenderer.ts

This file was deleted.

Loading

0 comments on commit a80c6fc

Please sign in to comment.