Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag to re-arrange custom columns not working #1282

Closed
mofojed opened this issue May 10, 2023 · 1 comment · Fixed by #1299
Closed

Drag to re-arrange custom columns not working #1282

mofojed opened this issue May 10, 2023 · 1 comment · Fixed by #1299
Labels
bug Something isn't working
Milestone
May 2023

Comments

@mofojed
Copy link
Member

mofojed commented May 10, 2023

Description

In the Grid Custom Columns side bar, unable to drag to re-arrange columns.

Steps to reproduce

  1. Create a table, e.g.
from deephaven import empty_table
t = empty_table(100).update("x=i")
  1. In the Custom Columns menu in the table side bar, add two custom columns, e.g. TEST1, TEST2, with just 1 and 2 as values
  2. Drag the handle to re-arrange the custom columns

Expected results

  1. The columns should be dragged and re-arrange

Actual results

  1. Columns do not get dragged

Additional details and attachments
Peek 2023-05-10 09-25

Versions

Engine Version: 0.25.0
Web UI Version: 0.38.0
Java Version: 11.0.18
Barrage Version: 0.5.0
OS: Ubuntu 22.04
Browser: Chrome 112.0.5615.49
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels May 10, 2023
@vbabich vbabich added this to the May 2023 milestone May 10, 2023
@vbabich vbabich removed the triage Issue requires triage label May 10, 2023
@dsmmcken
Copy link
Contributor

Also broken in silverheels

dsmmcken added a commit that referenced this issue May 15, 2023
@dsmmcken
fix: drag to re-arrange custom columns not working
0ef1fd3 
resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component.
Revert to previous button. Needs silverheels cherry-pick.
@dsmmcken dsmmcken mentioned this issue May 15, 2023
Merged
dsmmcken added a commit that referenced this issue May 16, 2023
@dsmmcken
fix: drag to re-arrange custom columns not working (#1299)
5e23e4a 
resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component,
added support for spreading.
Needs silverheels cherry-pick.
dsmmcken added a commit that referenced this issue May 16, 2023
@dsmmcken
fix: drag to re-arrange custom columns not working (#1299)
79ca688 
resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component,
added support for spreading.
Needs silverheels cherry-pick.
@dsmmcken dsmmcken mentioned this issue May 16, 2023
Merged
dsmmcken added a commit that referenced this issue May 16, 2023
@dsmmcken
fix: drag to re-arrange custom columns not working (#1299) (#1302)
0984632 
resolves: #1282

Broken by #1013. Can't use prop spreading with our Button component,
added support for spreading.
Needs silverheels cherry-pick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

fix: drag to re-arrange custom columns not working deephaven/web-client-ui
3 participants
@dsmmcken @vbabich @mofojed