Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save or discard a changed notebook does not close modal on first click #1187

Closed
mattrunyon opened this issue Mar 30, 2023 · 0 comments · Fixed by #1188
Closed

Save or discard a changed notebook does not close modal on first click #1187

mattrunyon opened this issue Mar 30, 2023 · 0 comments · Fixed by #1188
Assignees
@mattrunyon
Labels
bug Something isn't working
Milestone
March 2023

Comments

@mattrunyon
Copy link
Collaborator

Description

When you close a notebook with changes, if you click discard or save, the modal does not close. If you click the button again the modal closes. I believe this broke in #1040. The issue is we're relying on a state change in the beforeClose golden-layout event, but that event fires outside the React state loop

Steps to reproduce

  1. Open a notebook and make changes
  2. Close the notebook
  3. Click discard or save changes

Expected results

  1. Action fires and modal closes

Actual results

  1. Action fires and modal remains open. After clicking the button again, the modal closes

Versions

  • Web UI Version: 0.28.0
@mattrunyon mattrunyon added the bug Something isn't working label Mar 30, 2023
@mattrunyon mattrunyon added this to the March 2023 milestone Mar 30, 2023
@mattrunyon mattrunyon self-assigned this Mar 30, 2023
@mattrunyon mattrunyon mentioned this issue Mar 30, 2023
Merged
@mattrunyon mattrunyon changed the title Save or discard a changed notebook does not close modal Save or discard a changed notebook does not close modal on first click Mar 30, 2023
mattrunyon added a commit that referenced this issue Mar 30, 2023
@mattrunyon
fix: Save or discard a changed notebook does not close modal on first…
bba2d01 
… click (#1188)

Fixes #1187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

fix: Save or discard a changed notebook does not close modal on first click mattrunyon/web-client-ui
1 participant
@mattrunyon