You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you close a notebook with changes, if you click discard or save, the modal does not close. If you click the button again the modal closes. I believe this broke in #1040. The issue is we're relying on a state change in the beforeClose golden-layout event, but that event fires outside the React state loop
Steps to reproduce
Open a notebook and make changes
Close the notebook
Click discard or save changes
Expected results
Action fires and modal closes
Actual results
Action fires and modal remains open. After clicking the button again, the modal closes
Versions
Web UI Version: 0.28.0
The text was updated successfully, but these errors were encountered:
mattrunyon
changed the title
Save or discard a changed notebook does not close modal
Save or discard a changed notebook does not close modal on first click
Mar 30, 2023
Description
When you close a notebook with changes, if you click discard or save, the modal does not close. If you click the button again the modal closes. I believe this broke in #1040. The issue is we're relying on a state change in the
beforeClose
golden-layout event, but that event fires outside the React state loopSteps to reproduce
Expected results
Actual results
Versions
The text was updated successfully, but these errors were encountered: