Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conditional formatting not being applied to custom columns #1181

Conversation

emilyhuxng
Copy link
Contributor

@emilyhuxng emilyhuxng commented Mar 29, 2023

Fixes #1135

Removed getCachedModelColumns and uses model.columns instead.

@emilyhuxng emilyhuxng added this to the March 2023 milestone Mar 29, 2023
@emilyhuxng emilyhuxng requested a review from mofojed March 29, 2023 05:51
@emilyhuxng emilyhuxng self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #1181 (8cff155) into main (778346c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1181      +/-   ##
==========================================
- Coverage   44.16%   44.16%   -0.01%     
==========================================
  Files         447      447              
  Lines       33275    33273       -2     
  Branches     8357     8357              
==========================================
- Hits        14696    14694       -2     
  Misses      18530    18530              
  Partials       49       49              
Flag Coverage Δ
unit 44.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGrid.tsx 26.96% <ø> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a note to my previous comment from @vbabich 's change for Conditional Formatting: https://github.com/deephaven/web-client-ui/pull/409/files#r812346032
It appears this render loop is no longer the case - I tried adding/removing custom columns and conditional formatting, and didn't get stuck in a render loop (kept Profiler open to see when redraws occurred).
I think this issue was resolved with the changes for #986 or #1013.

@emilyhuxng emilyhuxng merged commit 1e4f8f9 into deephaven:main Mar 29, 2023
@emilyhuxng emilyhuxng deleted the bug-1135-conditional-formatting-not-being-applied-to-custom-columns branch March 29, 2023 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional formatting not being applied to custom columns
2 participants