Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional formatting not being applied to custom columns #1135

Closed
dsmmcken opened this issue Mar 6, 2023 · 0 comments · Fixed by #1181
Closed

Conditional formatting not being applied to custom columns #1135

dsmmcken opened this issue Mar 6, 2023 · 0 comments · Fixed by #1181
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Mar 6, 2023

Steps to reproduce

  1. Take any or the one given below, and add a new column to it using the custom columns UI feature in the table sidebar. For example a new column named "Test" equal to "MyInt * MyLong"
  2. Apply a conditional format using the table sidebar to that new column. For example "Test", "Is greater than" "0" and a color.
from deephaven import time_table

simple_ticking = time_table("00:00:01").update([
        "MyString=new String(`a`+i)",
        "MyInt=new Integer(i)",
        "MyLong=new Long(i)",
        "MyDouble=new Double(i+i/10)",
        "MyFloat=new Float(i+i/10)",
        "MyBoolean=new Boolean(i%2==0)",
        "MyChar= new Character((char) ((i%26)+97))",
        "MyShort=new Short(Integer.toString(i%32767))",
        "MyByte= new java.lang.Byte(Integer.toString(i%127))"])

Expected results

Color is applied to the column

Actual results

Nothing happens. No errors or anything in the console log, just doesn't apply.

Versions

Engine Version: 0.22.0
Web UI Version: 0.30.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken dsmmcken added bug Something isn't working triage Issue requires triage labels Mar 6, 2023
@vbabich vbabich added this to the March 2023 milestone Mar 8, 2023
@vbabich vbabich removed the triage Issue requires triage label Mar 8, 2023
@mofojed mofojed removed their assignment Mar 27, 2023
@emilyhuxng emilyhuxng self-assigned this Mar 27, 2023
emilyhuxng added a commit that referenced this issue Mar 29, 2023
Fixes #1135 

Removed `getCachedModelColumns` and uses `model.columns` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants