fix: Grid rendering header incorrectly when hiding all children in a group via layout hints #1139
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 43.40% 43.41% +0.01%
==========================================
Files 435 435
Lines 32682 32688 +6
Branches 8240 8244 +4
==========================================
+ Hits 14185 14193 +8
+ Misses 18448 18446 -2
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -110,7 +110,7 @@ const config: PlaywrightTestConfig = { | |||
| webServer: { | |||
| // Only start the main code-studio server right now | |||
| // To test embed-grid and embed-chart, should have an array set for `webServer` and run them all separately as there's a port check | |||
| command: 'VITE_PROXY_URL=http://localhost:10000 npm run preview:app', | |||
| command: 'npm run preview:app -- -- -- --no-open', // Passing flags through npm is fun | |||
| RUN npm run build:app |
There was a problem hiding this comment.
When we were using CRA, there was no proxy server, so if we wanted to point to a JS API not reachable at /jsapi on our preview server, we needed to build it w/ a URL instead.
Prior to #1102 we only proxied requests in dev mode for Vite. With that change, we proxy requests for the Vite preview server as well. So now we can build expecting /jsapi to resolve properly since it will go through the proxy which defaults to localhost:10000
Fixes #1097
Also updated the readme for updating e2e snapshots and removed some env variables that shouldn't be needed any more when updating/running e2e tests