useGetItemIndexByValue error handling (#1889)

deephaven · Apr 1, 2024 · fe09fa6 · fe09fa6
1 parent de2aa6d
commit fe09fa6
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/packages/jsapi-components/src/useGetItemIndexByValue.test.ts b/packages/jsapi-components/src/useGetItemIndexByValue.test.ts
@@ -54,6 +54,22 @@ describe('useGetItemIndexByValue', () => {
     }
   );
 
+  it('should return null if seekRow fails', async () => {
+    asMock(mockTable.seekRow).mockRejectedValue('Some error');
+
+    const { result } = renderHook(() =>
+      useGetItemIndexByValue({
+        columnName: 'mock.columnName',
+        table: mockTable,
+        value: 'mock.value',
+      })
+    );
+
+    const actual = await result.current();
+
+    expect(actual).toBeNull();
+  });
+
   it.each([
     ['mock.value', 42, 42],
     ['mock.value', -1, null],

diff --git a/packages/jsapi-components/src/useGetItemIndexByValue.ts b/packages/jsapi-components/src/useGetItemIndexByValue.ts
@@ -1,7 +1,10 @@
 import { useCallback } from 'react';
 import { dh } from '@deephaven/jsapi-types';
+import Log from '@deephaven/log';
 import { useTableUtils } from './useTableUtils';
 
+const log = Log.module('useGetItemIndexByValue');
+
 /**
  * Returns a function that gets the index of the first row containing a column
  * value.
@@ -30,9 +33,13 @@ export function useGetItemIndexByValue<TValue>({
     const column = table.findColumn(columnName);
     const columnValueType = tableUtils.getValueType(column.type);
 
-    const index = await table.seekRow(0, column, columnValueType, value);
-
-    return index === -1 ? null : index;
+    try {
+      const index = await table.seekRow(0, column, columnValueType, value);
+      return index === -1 ? null : index;
+    } catch (err) {
+      log.debug('Error seeking row', { column, value, columnValueType });
+      return null;
+    }
   }, [columnName, table, tableUtils, value]);
 }