Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
- Add async to methods for consistency
  • Loading branch information
mofojed committed Jan 8, 2024
1 parent cbd28aa commit f4cba3a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/iris-grid/src/IrisGridPartitionedTableModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ class IrisGridPartitionedTableModel
return this.partitionedTable.keyColumns;
}

partitionKeysTable(): Promise<Table> {
async partitionKeysTable(): Promise<Table> {
return this.partitionedTable.getKeyTable();
}

partitionMergedTable(): Promise<Table> {
async partitionMergedTable(): Promise<Table> {
return this.partitionedTable.getMergedTable();
}

Expand Down
2 changes: 1 addition & 1 deletion packages/iris-grid/src/IrisGridTableModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ class IrisGridTableModel
return this.getCachedPartitionColumns(this.columns);
}

partitionKeysTable(): Promise<Table> {
async partitionKeysTable(): Promise<Table> {
return this.valuesTable(this.partitionColumns);
}

Expand Down

0 comments on commit f4cba3a

Please sign in to comment.