-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build(@deephaven/icons): Properly package icons and remove unnecessar…
…y files in dist (#1437) While updating packages consumed in the docs, I noticed our icons `package.json` was off. It specified it was a module type (ESM), but exported CJS as `.js`. This is incorrect as those will be interpreted as ESM by Node. Instead we should be exporting a `.cjs` file and a `.js` or `.mjs` as the main file. Added an exports section to the `package.json` to indicate which file is for ESM and which is for CJS. We still need to distribute CJS for Jest tests. Removed unnecessary files from the distribution. We don't use imports like `import vsTrash from '@deephaven/icons/vsTrash';` and the ESM tree shakes, so I removed the individual files exported. They also would have been imported from `/icons/dist` which is bad practice. Removed the SVG files from the files for the published package as well since they aren't used by anything in production. BREAKING CHANGE: Any imports/aliasing to `@deephaven/icons/dist` should be removed and just read the package contents normally (e.g. DHE jest and vite configs for using community packages locally). See the changes to vite and jest configs in this change for how to update
- Loading branch information
1 parent
6e0b60e
commit ec7ccef
Showing
8 changed files
with
42 additions
and
126 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters