Address review comments

deephaven · Apr 17, 2023 · d84daf5 · d84daf5
1 parent ecf1526
commit d84daf5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/dashboard-core-plugins/src/linker/Linker.tsx b/packages/dashboard-core-plugins/src/linker/Linker.tsx
@@ -355,10 +355,12 @@ export class Linker extends Component<LinkerProps, LinkerState> {
         }
         case 'chartLink': {
           const existingLinkEnd = isReversed === true ? start : end;
+          const existingLinkStart = isReversed === true ? end : start;
           log.debug('creating chartlink', { existingLinkEnd, start, end });
           // Don't allow linking more than one column per source to each chart column
           const linksToDelete = links.filter(
-            ({ end: panelLinkEnd }) =>
+            ({ end: panelLinkEnd, start: panelLinkStart }) =>
+              panelLinkStart?.panelId === existingLinkStart.panelId &&
               panelLinkEnd?.panelId === existingLinkEnd.panelId &&
               panelLinkEnd?.columnName === existingLinkEnd.columnName &&
               panelLinkEnd?.columnType === existingLinkEnd.columnType

diff --git a/packages/dashboard-core-plugins/src/panels/ChartPanel.tsx b/packages/dashboard-core-plugins/src/panels/ChartPanel.tsx
@@ -797,7 +797,7 @@ export class ChartPanel extends Component<ChartPanelProps, ChartPanelState> {
           return;
         }
         if (filterList.length < 1) {
-          log.error('Invalid filterMap, filterList is empty', filterMapParam);
+          log.debug('Ignoring empty filterList for column', columnName);
           return;
         }
         const { value } = filterList[0];