Skip to content

Commit

Permalink
Try removing lerna hoist, node_modules cache, and parallel tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mattrunyon committed Apr 29, 2021
1 parent 50e5c8f commit 90d1c21
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Cache node_modules
id: cache-node-modules
uses: actions/cache@v2
with:
# If no package-locks have changed, it should be safe to restore all node_modules as they were
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ hashFiles('**/package-lock.json') }}

- name: Cache npm cache
uses: actions/cache@v2
env:
Expand All @@ -56,9 +48,7 @@ jobs:
${{ runner.os }}-eslintcache-
${{ runner.os }}-
# Only need to install and bootstrap deps if package-locks changed
- name: Install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: npm ci

- name: Test
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"clean:build": "lerna run clean --stream",
"clean:modules": "lerna clean --yes",
"clean": "npm run clean:build && npm run clean:modules",
"bootstrap": "lerna bootstrap --hoist",
"bootstrap": "lerna bootstrap",
"build": "lerna run build --stream",
"build:app": "lerna run --scope=@deephaven/code-studio build",
"build:packages": "lerna run --ignore=@deephaven/code-studio build --stream",
Expand All @@ -21,7 +21,7 @@
"prestart": "lerna run prestart --stream",
"pretest:ci": "npm run build:packages",
"test": "lerna run test --stream --parallel",
"test:ci": "lerna run test:ci --stream --parallel",
"test:ci": "lerna run test:ci --stream",
"sync-version": "lerna version ${DEEPHAVEN_VERSION:-error} --no-git-tag-version --yes",
"publish": "lerna publish"
},
Expand Down

0 comments on commit 90d1c21

Please sign in to comment.