feat: UI Component Range Calendar #930
Conversation
dgodinez-dh
requested review from
a team,
bmingles and
jnumainville
and removed request for
a team
@dsmmcken |
separate PR, but this PR should include it's entry. |
plugins/ui/DESIGN.md
Outdated
| default_value={"start": local_start, "end": local_end} | ||
| ) | ||
|
|
||
| # simple range calendar that takes list view items directly and is controlled |
There was a problem hiding this comment.
Did you mean to say "list view items" here, or is this a copy / paste artifact?
There was a problem hiding this comment.
Yes. That was a copy / paste artifact. Updated.
plugins/ui/docs/sidebar.json
Outdated
| "label": "range_calendar", | ||
| "path": "components/range_slider.md" | ||
| }, | ||
| { | ||
| "label": "range_slider", | ||
| "path": "components/range_calendar.md" | ||
| }, |
There was a problem hiding this comment.
that doesn't look right, label and paths are swapped
| ...otherProps | ||
| } = useRangeCalendarProps(props); | ||
|
|
||
| const [value, onChange] = useDebouncedOnChange<RangeValue<DateValue> | null>( |
There was a problem hiding this comment.
This seems to make the component always controlled. If the default_value prop is updated, it changes the value.
e.g.
from deephaven import ui
@ui.component
def example():
default_value, set_default_value = ui.use_state({"start": "2020-02-03", "end": "2020-02-08"})
return ui.range_calendar(
aria_label="Date range (uncontrolled)",
default_value=default_value,
), ui.button('Update default', on_press=lambda _: set_default_value({"start": "2020-02-09", "end": "2020-02-20"}))
my_example = example()
|
|
||
| it('handles a CalendarDateTime', () => { | ||
| const date = new CalendarDateTime(2021, 3, 4, 5, 6, 7); | ||
| expect(dateValuetoIsoString(date)).toEqual('2021-03-04T05:06:07Z'); |
There was a problem hiding this comment.
I like the sequential numbering. Makes it easy to see the relationship of the input / output.
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
closes #904
closes #854