feat: Use useWidget hook to load widgets (#502)
#555
Merged
+3,434
−12,626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs deephaven/web-client-ui#2030 - Uses the `useWidget` hook defined in deephaven/web-client-ui#2030 to load widgets - Allows for the errors/fetch implementation to be defined at the top level - Needed for DH-16737 - Tested in Core with a bunch of widgets, works as expected - Unit tests added
mattrunyon
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useWidgethook web-client-ui#2030useWidgethook defined in feat: DH-16737 Add ObjectManager,useWidgethook web-client-ui#2030 to load widgets