-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nx
dependency
#560
Comments
I don't think we can remove the dependency entirely. It's required for lerna and lerna is what we use for running tasks. We can disable or run w/ |
We don't have a dependency on |
Removing it from our |
Rollup and esbuild optional dependencies were removed from the package-lock by this PR: #502 Adding them back to top level `optionalDependencies` to ensure they are available For reference to get this list I: 1. used `vscode` file history to find the package-lock.json diff that removed the dependencies. 2. copy / pasted the removed blocks of `esbuild` and `rollup` dependencies into a new `.json` file 3. Used `jq` to flatten the names + versions `cat myfile.json | jq 'with_entries(.value = .value.version)'` 4. Tweak / copy / pasted into optionalDependencies resolves #560
We currently have
useNx
enabled for lerna in the plugins repo. Unfortunately nx has optional architecture specific dependencies that intermittently cause us issues sincenpm
doesn't always install optional dependencies of dependencies.One option to fix this is to hoist the optional dependencies to the root (tried in rejected PR #471)
The other / preferable option would be to just remove the
nx
dependency altogether.The text was updated successfully, but these errors were encountered: