Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.picker implementation in Python passing props through #294

Closed
Tracked by #200
mofojed opened this issue Feb 20, 2024 · 0 comments · Fixed by #311
Closed
Tracked by #200

ui.picker implementation in Python passing props through #294

mofojed opened this issue Feb 20, 2024 · 0 comments · Fixed by #311
Assignees
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Feb 20, 2024

Implement the Python side to spec: #247 . Add pydocs for each prop.
Add additional Spectrum props that are documented and easy to pass through (e.g. serializable): https://react-spectrum.adobe.com/react-spectrum/Picker.html#props

  • Some props like validate takes a callback function which we won't be able to pass through. Take a note of these props we don't pass through on the PR for now.
@mofojed mofojed mentioned this issue Feb 20, 2024
6 tasks
@mofojed mofojed added this to the February 2024 milestone Feb 20, 2024
bmingles pushed a commit that referenced this issue Feb 27, 2024
Fixes #294
Creates python side of picker component along with section and items.

Props that are not currently supported:
`items` - we don't support passing in a callback as a child and we
support passing in lists in `children`, so this will not be supported
`validate` - is a callback we don't support
`errorMessage` - specifically a callback
`onLoadMore` - irrelevant due to supporting a table source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants