-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidirectional Communication #11
Conversation
@@ -28,35 +28,128 @@ class Exporter(abc.ABC): | |||
|
|||
@abc.abstractmethod | |||
def reference( | |||
self, object, allow_unknown_type: bool = False, force_new: bool = False | |||
self, obj: object, allow_unknown_type: bool = False, force_new: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self, obj: object, allow_unknown_type: bool = False, force_new: bool = False | |
self, obj: Any, allow_unknown_type: bool = False, force_new: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #12
@mattrunyon worked me through the changes which mostly make sense. But I was having a hard time imaging how an user would be able to create a custom plugin on his own with the limited documentation. Maybe we can direct them to https://github.com/deephaven/deephaven-core/tree/779787bd9b374434290e7d47769d84e0c507d36d/py/server/deephaven/pandasplugin for a working example. But overall I find the naming in the API to be a bit confusing and the explanations of the purpose of many methods and the relationship between the classes not very helpful. |
Superseded by #12 |
Augments
ObjectType
to support bidirectional communication. Adds a newBidiObjectBase
which objects that a plugin handles can extend if they wish to support bidi communication.Needs deephaven/deephaven-core#4086 to work properly