Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release procedure to add jars as assets. #152

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,16 @@ jobs:
- name: Publish
# Note: even though we specify org.gradle.parallel=false in our CI gradle.properties, we want to be explicit
# here about no parallelism to ensure we don't create disjointed staging repositories.
run: ./gradlew --no-parallel publish
run: ./gradlew --no-parallel assemble publish
env:
ORG_GRADLE_PROJECT_ossrhUsername: ${{ secrets.SONATYPE_USERNAME }}
ORG_GRADLE_PROJECT_ossrhPassword: ${{ secrets.SONATYPE_PASSWORD }}
ORG_GRADLE_PROJECT_signingKey: ${{ secrets.CI_AT_DEEPHAVEN_KEY }}
ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.CI_AT_DEEPHAVEN_PASSWORD }}
ORG_GRADLE_PROJECT_signingRequired: true

- name: Upload Artifacts
uses: actions/upload-artifact@v3
with:
path: |
**/build/libs/**
5 changes: 5 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ $ git push -u upstream release/vX.Y.Z
### 4. Monitor release

The release will proceed with [GitHub Actions](https://github.com/deephaven/deephaven-csv/actions/workflows/publish.yml).
Upon completion, the publish workflow will upload the jars as artifacts. There should be 7 jars in total:
`deephaven-csv`'s `.jar`, `-javadoc.jar`, `-sources.jar`, and `-jmh.jar`; `deephaven-csv-fast-double-parser`'s `.jar`,
`-javadoc.jar`, and `-sources.jar`. Download these artifacts for later upload as part of the GitHub release.

### 5. Maven Central jars

Expand Down Expand Up @@ -114,4 +117,6 @@ Create a new [GitHub release](https://github.com/deephaven/deephaven-csv/release

The convention is to have the Release title of the form `vX.Y.Z` and to autogenerate the release notes in comparison to the previous release tag.

Upload the 7 jar artifacts downloaded from the publish workflow as assets for the release.

Hit the GitHub "Publish release" button.