Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ADVANCED.md #108

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix typo in ADVANCED.md #108

merged 1 commit into from
Apr 12, 2023

Conversation

kaklakariada
Copy link
Contributor

Thank you for this sophisticated library and the helpful documentation!

I found a minor typo in the documentation.

@devinrsmith devinrsmith self-requested a review April 6, 2023 14:24
@devinrsmith devinrsmith added the documentation Improvements or additions to documentation label Apr 6, 2023
@devinrsmith
Copy link
Member

Thanks for the kind words @kaklakariada - sorry it's taken this long for me to get back to this. We had a missing CLA workflow on this repo that I've now remedied. Going forward in the future the process will be more automated - but as of now, to merge this PR we'll need one of:

  • Sign the CLA vs the temporary PR CLA assistant workaround #111
  • Create and push a new commit to this PR (an empty commit, a rebase, or merge from main should all work), and then accept the new CLA dialog that shows up here

Thanks for your contribution :)

@devinrsmith devinrsmith merged commit 1e42801 into deephaven:main Apr 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
@kaklakariada kaklakariada deleted the fix-typo branch April 12, 2023 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants