Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpp-client): Fix certain error messages #5988

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Aug 26, 2024

The string concatenation was happening in the wrong place, so the original code was producing messages like

due to unexpected exception with message:
  gethostname failed: error code : class std::basic_string<char,struct std::
  char_traits<char>,class std::allocator<char> > __cdecl deephaven::dhcore::
  utility::GetHostname(void)@C:\Users\kosak\git\deephaven-core\cpp-client\
  deephaven\dhcore\src\utility\utility_platform_specific.cc:6710093

In the above the Windows error code is "10093" and the line number is "67".

The original code was mashing together both into 6710093

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 26, 2024
@kosak kosak requested a review from jcferretti August 26, 2024 03:36
@kosak kosak self-assigned this Aug 26, 2024
@kosak kosak merged commit 5fc0504 into deephaven:main Aug 26, 2024
22 checks passed
@kosak kosak deleted the kosak_fix-error-messages branch August 26, 2024 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants