Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract base class for Assert/Require #5774

Closed
wants to merge 3 commits into from
Closed

refactor: Extract base class for Assert/Require #5774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c45fa70
Extract a base class for Assert and Require
niloc132 Jul 15, 2024
7d8e628
Update callers that will be transpiled to JS
niloc132 Jul 15, 2024
ad6ce61
Copy javadoc, spotless
niloc132 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,386 changes: 1 addition & 1,385 deletions Base/src/main/java/io/deephaven/base/verify/Assert.java
View file
Open in desktop

Large diffs are not rendered by default.

1,453 changes: 1,453 additions & 0 deletions Base/src/main/java/io/deephaven/base/verify/AssertBase.java
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Base/src/main/java/io/deephaven/base/verify/ExceptionMessageUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public static String valueString(char c) {
* @return new string filled with the character <i>c</i>
*/
public static String fillChar(char c, int count) {
Require.gtZero(count, "count");
RequireBase.gtZero(count, "count");
char[] buffer = new char[count];
// note: this is faster than System.arraycopy unless count>~100
for (int nIndex = 0; nIndex < count; nIndex++) {
Expand Down
Loading
Loading