Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mark JsPartitionedTable.getTable as nullable #5050

Merged
merged 3 commits into from
Mar 7, 2024
Merged

fix: Mark JsPartitionedTable.getTable as nullable #5050

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
810bf26
fix: Reject instead of returning a null table
mofojed Jan 18, 2024
efcbe50
Revert "fix: Reject instead of returning a null table"
mofojed Feb 14, 2024
18aaa32
Add @Nullable notation to return result
mofojed Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions web/client-api/src/main/java/io/deephaven/web/client/api/JsPartitionedTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import io.deephaven.web.shared.data.RangeSet;
import jsinterop.annotations.JsIgnore;
import jsinterop.annotations.JsMethod;
import jsinterop.annotations.JsNullable;
import jsinterop.annotations.JsProperty;
import jsinterop.annotations.JsType;
import jsinterop.base.Js;
Expand Down Expand Up @@ -157,12 +158,12 @@ private void handleKeys(Event update) {
}

/**
* Fetch the table with the given key.
* Fetch the table with the given key. If the key does not exist, returns `null`.
*
* @param key The key to fetch. An array of values for each key column, in the same order as the key columns are.
* @return Promise of dh.Table
* @return Promise of dh.Table, or `null` if the key does not exist.
*/
public Promise<JsTable> getTable(Object key) {
public Promise<@JsNullable JsTable> getTable(Object key) {
// Wrap non-arrays in an array so we are consistent with how we track keys
if (!JsArray.isArray(key)) {
key = JsArray.of(key);
Expand Down
Loading