Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing of #4756, I discovered that
io.deephaven.server.util.Scheduler
andio.deephaven.util.reference.CleanupReferenceProcessor
threads were leaking. CI testing was throwing "can't create more threads" errors due to the addition of a large number of new java client async tests which pushed the leaked thread counts over some JVM limit.As concrete evidence of the leaks, I ran
and got
This PR adds an unit-test-only shutdown procedure for the Scheduler; if we wanted to actually change the Scheduler interface to support this, it would require more work and testing. This also ensures that CleanupReferenceProcessor are promptly cleaned up (instead of eventually).