Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make newTable, emptyTable flat. Fix flatten. #4598

Merged

Conversation

devinrsmith
Copy link
Member

Originally reported by @elijahpetty. Noticed that

t1 = newTable(
    stringCol("Title", "content"),
    stringCol("ColumnName", "column_content")
)

println t1.isFlat()

t1.flatten()

println t1.isFlat()

printed out false then true. This change makes sure that newTable and emptyTable produces an isFlat() Table out of the box, as well as ensuring that Table.flatten doesn't modify the existing table.

@devinrsmith devinrsmith added this to the September 2023 milestone Oct 4, 2023
@devinrsmith devinrsmith self-assigned this Oct 4, 2023
@devinrsmith devinrsmith removed the request for review from arman-ddl October 4, 2023 21:18
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@devinrsmith devinrsmith requested a review from rcaudy October 4, 2023 21:54
@devinrsmith devinrsmith enabled auto-merge (squash) October 4, 2023 21:56
@devinrsmith devinrsmith merged commit e1a933e into deephaven:main Oct 4, 2023
@devinrsmith devinrsmith deleted the nightly/query-table-flatten-copy branch October 4, 2023 22:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants