-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the creation of R Clients from other libraries (useful for DnD and in general) #4441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need, at minimum:
- Test case for providing an XPtr to the Client constructor.
a. Construct a client connection fromclient1 <- Client$new(target = ...)
b. Create a simple static table withempty_table
and bind to a variable
c. Extract the external pointer withxptr <- client1$.internal_rcpp_object$.pointer
d. Construct a client connection fromclient2 <- Client$new(xptr)
e. Verify you can pull table withclient2$open_table("table")
- A test case where the first and only argument to
Client$new()
is not a string, not a list, and not an external pointer. Error handling as appropriate. - If
make_table_handle_from_ticket
is for external use, we need an R6-level wrapping, error handling, and (at least) negative tests as appropriate. If it is internal use, I do not see any cases of its usage.
Figure out an informative error when argument 1 to Client$new()
is not acceptable, and mention that we will also accept external pointers to existing client connections.
Tests passing at this point, including new tests for arguments to
|
I ran the testthat tests, they are passing.