Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support on close callbacks for C++ client #4417

Merged
merged 8 commits into from
Aug 31, 2023
Merged

Support on close callbacks for C++ client #4417

merged 8 commits into from
Aug 31, 2023

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti added this to the August 2023 milestone Aug 31, 2023
@jcferretti jcferretti requested a review from kosak August 31, 2023 01:02
@jcferretti jcferretti self-assigned this Aug 31, 2023
@jcferretti
Copy link
Member Author

The new test passes:

cfs@caicai 20:58:13 ~/dh/oss1/deephaven-core/cpp-client/deephaven/build/tests
$ ./tests "On Close Callbacks can be added and removed and are executed"
Filters: On Close Callbacks can be added and removed and are executed
Connecting to localhost:10000
===============================================================================
All tests passed (3 assertions in 1 test case)

@jcferretti jcferretti enabled auto-merge (squash) August 31, 2023 01:03
@jcferretti jcferretti disabled auto-merge August 31, 2023 01:03
@jcferretti jcferretti enabled auto-merge (squash) August 31, 2023 03:00
kosak
kosak previously approved these changes Aug 31, 2023
View reviewed changes
@jcferretti jcferretti disabled auto-merge August 31, 2023 03:32
@jcferretti jcferretti enabled auto-merge (squash) August 31, 2023 03:32
@jcferretti jcferretti merged commit 3c71031 into deephaven:main Aug 31, 2023
@jcferretti jcferretti deleted the cfs-client-on-close-cb branch August 31, 2023 04:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kosak kosak kosak approved these changes

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@jcferretti @kosak