Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jackson from the public API of extensions-parquet-table #4403

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Remove jackson from the public API of extensions-parquet-table #4403

merged 1 commit into from
Aug 30, 2023

Conversation

devinrsmith
Copy link
Member

Afaict, this was the only instance in this project where jackson was exposed. There are annotations attached to public objects, but that doesn't effect the public API. Tooling related to #4401 may help automate this process and eliminate bugs like this from happening in the future.

Fixes #4402

@devinrsmith
Remove jackson from the public API of extensions-parquet-table
d0721b1 
Afaict, this was the only instance in this project where jackson was exposed.
There are annotations attached to public objects, but that doesn't effect the
public API. Tooling related to deephaven#4401 may help automate this process and
eliminate bugs like this from happening in the future.

Fixes deephaven#4402
@devinrsmith devinrsmith added bug Something isn't working clean up NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Aug 29, 2023
@devinrsmith devinrsmith added this to the August 2023 milestone Aug 29, 2023
@devinrsmith devinrsmith requested a review from rcaudy August 29, 2023 20:09
@devinrsmith devinrsmith self-assigned this Aug 29, 2023
@devinrsmith devinrsmith merged commit 046b363 into deephaven:main Aug 30, 2023
@devinrsmith devinrsmith deleted the remove-jackson-from-public-api branch August 30, 2023 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
@devinrsmith
Copy link
Member Author

devinrsmith commented Aug 30, 2023 •
edited
Loading

I was able to further test that this does fix the publicly exposed API via https://github.com/devinrsmith/aeropress:

Before this PR:

$ aeropress-cli server/jetty-app/build/install/server-jetty/lib/deephaven-extensions-parquet-table-0.28.0.jar
deephaven-Base-0.28.0.jar
deephaven-Util-0.28.0.jar
deephaven-engine-api-0.28.0.jar
deephaven-engine-chunk-0.28.0.jar
deephaven-engine-rowset-0.28.0.jar
deephaven-engine-stringset-0.28.0.jar
deephaven-engine-table-0.28.0.jar
deephaven-engine-vector-0.28.0.jar
deephaven-extensions-parquet-base-0.28.0.jar
deephaven-extensions-parquet-table-0.28.0.jar
jackson-core-2.15.1.jar
parquet-column-1.13.0.jar
parquet-hadoop-1.13.0.jar

After this PR:

$ aeropress-cli server/jetty-app/build/install/server-jetty/lib/deephaven-extensions-parquet-table-0.28.0.jar
deephaven-Base-0.28.0.jar
deephaven-Util-0.28.0.jar
deephaven-engine-api-0.28.0.jar
deephaven-engine-chunk-0.28.0.jar
deephaven-engine-rowset-0.28.0.jar
deephaven-engine-stringset-0.28.0.jar
deephaven-engine-table-0.28.0.jar
deephaven-engine-vector-0.28.0.jar
deephaven-extensions-parquet-base-0.28.0.jar
deephaven-extensions-parquet-table-0.28.0.jar
parquet-column-1.13.0.jar
parquet-hadoop-1.13.0.jar

Notice, jackson-core-2.15.1.jar is no longer present in output.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@devinrsmith devinrsmith

Labels
bug Something isn't working clean up NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Compilation against extensions-parquet-table requires jackson
2 participants
@devinrsmith @rcaudy