Update cpp client roaring version to v1.3.0 #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
kosak
approved these changes
Jun 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of roaring files from 0.7.1 to 1.3.0.
I checked the existing version, the headers produced by amalgamation.sh declared the version we were using to be 0.7.1.
Downloading that version and comparing the files with diff confirmed that was the case, we were using unmodified 0.7.1 versions of the 3 files (.cc, .h, .hh).
I used amalgamation.sh over v1.3.0 (latest stable) to produce the new files in this PR, and did a basic smoke test with ticking data (ran cpp-examples/demos/chapter2 against a simple time table).