Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jedi SAFE mode #3176

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fix jedi SAFE mode #3176

merged 2 commits into from
Dec 12, 2022

Conversation

devinrsmith
Copy link
Member

@devinrsmith devinrsmith commented Dec 9, 2022 •
edited
Loading

Fixes #3177

@devinrsmith devinrsmith self-assigned this Dec 9, 2022
@devinrsmith devinrsmith added this to the Dec 2022 milestone Dec 9, 2022
@devinrsmith devinrsmith added bug Something isn't working NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed autocomplete labels Dec 9, 2022
@devinrsmith devinrsmith requested review from JamesXNelson and removed request for niloc132 December 12, 2022 16:31
JamesXNelson
JamesXNelson previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@JamesXNelson JamesXNelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Maybe move the comment about Script completer... to be inside the if block.

@devinrsmith devinrsmith mentioned this pull request Dec 12, 2022
Open
@devinrsmith devinrsmith merged commit 00a223d into deephaven:main Dec 12, 2022
@devinrsmith devinrsmith deleted the jedi-safe-mode branch December 12, 2022 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesXNelson JamesXNelson JamesXNelson approved these changes

Assignees

@devinrsmith devinrsmith

Labels
autocomplete bug Something isn't working NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Dec 2022
Development

Successfully merging this pull request may close these issues.

Jedi SAFE mode errors
2 participants
@devinrsmith @JamesXNelson