All project types should declare maven repositories #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
build
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested changes
Dec 6, 2022
buildSrc/src/main/groovy/io.deephaven.common-conventions.gradle
Outdated
Show resolved
Hide resolved
devinrsmith
approved these changes
Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix some nightly build issues going back a month or two, as some non-java projects still depend on java artifacts, either through transitively through project dependencies, or through plugins like spotless that resolve dependencies at runtime.