Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrage: apply redirection mapping is broken into disjoint groups #2942

Merged
merged 9 commits into from
Oct 11, 2022

Conversation

nbauernfeind
Copy link
Member

Fixes #2938

Redirection mapping is performed in four distinct groups:

  1. adds that are new adds
  2. mods that replace rows scope into a subscribed viewport
  3. mods that propagate as adds (the adds have not yet been propagated, but this modifies an add)
  4. mods that are just mods

Each one share the ArrayList of redirection mappings. Existing logic only would advance to the next mapping if the key matches the last row of that chunk -- however that row is only in one of the four groups. I now skip until I find the appropriate chunk that should be modified.

@nbauernfeind nbauernfeind added this to the Oct 2022 milestone Oct 4, 2022
@nbauernfeind nbauernfeind self-assigned this Oct 4, 2022
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review pass for row offset changes. We're going to need to go over BarrageStreamGenerator more carefully.

@nbauernfeind nbauernfeind merged commit e5d9c82 into deephaven:main Oct 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException after reading a lot of Barrage data
2 participants