-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barrage: apply redirection mapping is broken into disjoint groups #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Oct 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review pass for row offset changes. We're going to need to go over BarrageStreamGenerator more carefully.
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Show resolved
Hide resolved
rcaudy
reviewed
Oct 10, 2022
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/barrage/BarrageStreamGenerator.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2938
Redirection mapping is performed in four distinct groups:
Each one share the ArrayList of redirection mappings. Existing logic only would advance to the next mapping if the key matches the last row of that chunk -- however that row is only in one of the four groups. I now skip until I find the appropriate chunk that should be modified.