Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builders for GroupBy initialization and updates #2886

Merged
merged 29 commits into from
Sep 26, 2022
Merged
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6302b68
use RowSetBuilderRandom instead of RowSet.insert calls
lbooker42 Aug 24, 2022
506b644
Merge branch 'main' of github.com:lbooker42/deephaven-core
lbooker42 Aug 24, 2022
779898e
PT tests passing, spotless applied
lbooker42 Aug 24, 2022
a28e758
wip
lbooker42 Aug 25, 2022
9cd408d
updated PT to use builders
lbooker42 Sep 14, 2022
ef8985c
minor cleanup
lbooker42 Sep 14, 2022
8d1fcbf
pull upstream
lbooker42 Sep 14, 2022
d747f02
bugfix, re-scope setter for initialized flag
lbooker42 Sep 14, 2022
903bc6c
ported Builder improvements
lbooker42 Sep 14, 2022
b139642
pull upstream changes
lbooker42 Sep 16, 2022
c4fd810
PR comments round 1 addressed
lbooker42 Sep 16, 2022
69dc9da
can we get auto-spotless?
lbooker42 Sep 16, 2022
a29e655
add'l PR comments addressed
lbooker42 Sep 19, 2022
51f4c81
fixed a silly comment
lbooker42 Sep 19, 2022
abd7e21
extracted the local class to allow general usage
lbooker42 Sep 19, 2022
ba3567f
Using sequential builders to accelerate initial GroupBy creation
lbooker42 Sep 20, 2022
396d6c8
merge upstream
lbooker42 Sep 20, 2022
7f2496f
bugfix: enable tracking on rowset after build()
lbooker42 Sep 20, 2022
d4f163a
changes to allow more efficient updates (WIP)
lbooker42 Sep 21, 2022
e1665c1
WIP
lbooker42 Sep 21, 2022
c7340fe
COB WIP
lbooker42 Sep 21, 2022
5ddc31e
Aggregation Tests passing, still a little messy
lbooker42 Sep 22, 2022
6be2f49
cleaned up a bit, tests still passing
lbooker42 Sep 22, 2022
efc5186
removed anyKeysModified from propagateUpdates() in chunked aggregation
lbooker42 Sep 22, 2022
1452d4f
revert changes to resetForStep
lbooker42 Sep 22, 2022
6cf9374
spotless for the win
lbooker42 Sep 22, 2022
839d215
another round of comments addressed
lbooker42 Sep 26, 2022
813d34f
more spotless
lbooker42 Sep 26, 2022
7c3fff6
Moved BitmapRandomBuilder to a better home
lbooker42 Sep 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading