TicketResolver: return failed export object instead of throwing #2845
Conversation
| @@ -81,7 +79,7 @@ public void teardown() { | |||
| public void testDestroyOnExportRelease() { | |||
| final CountingLivenessReferent export = new CountingLivenessReferent(); | |||
| final SessionState.ExportObject<Object> exportObj; | |||
| try (final SafeCloseable scope = LivenessScopeStack.open()) { | |||
| try (final SafeCloseable ignored = LivenessScopeStack.open()) { | |||
There was a problem hiding this comment.
BTW, FYI, no action required, some PL people use the variable _ (that is, single underscore) to mean "dummy" or "ignored"
There was a problem hiding this comment.
That's a neat fact. I'm not sure if that was popular before Scala or not, but _ is a very heavy scala ism (where I picked the idea up). You can even use it as an unlabeled single parameter into a lambda (i.e. _.convertToInt(radix)). _ is an invalid identifier in java, so we can't do the same. IntelliJ auto suppresses unused warnings when the name is ignored.
There was a problem hiding this comment.
Ah, didn't realize _ was illegal in Java, thanks. I think I picked up the convention from Go and Rust (where _ is varying degrees of special).
There was a problem hiding this comment.
The reason that _ is illegal is that this is coming in a future release, they wanted to reserve it to not break existing code.
https://mail.openjdk.org/pipermail/amber-spec-experts/2022-September/003485.html
As with other languages, you will be able to mark more than one local as _, and it looks like even type params will be able to be _ (as opposed to ?).
The scope ticket resolver no longer throws an exception but instead returns an export object that is in a failed state. This allows commands downstream of a failed dependency to 1) be created, and 2) assume a dependency_failed state.