Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a unit test to verify that @FinalDefault is respected #2825

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Write a unit test to verify that @FinalDefault is respected #2825

merged 2 commits into from
Sep 8, 2022

Conversation

nbauernfeind
Copy link
Member

I also wrote tests for the test logic to ensure it catches different override patterns.

@nbauernfeind nbauernfeind added this to the Sept 2022 milestone Sep 8, 2022
@nbauernfeind nbauernfeind requested a review from rcaudy September 8, 2022 17:04
@nbauernfeind nbauernfeind self-assigned this Sep 8, 2022
rcaudy
rcaudy reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the runtime for the new test?

@nbauernfeind
Copy link
Member Author

What's the runtime for the new test?

It takes ~6s.

@nbauernfeind nbauernfeind merged commit e43cd36 into deephaven:main Sep 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
NoDocumentationNeeded table api test
Projects
None yet
Milestone
Sept 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @rcaudy