Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable formatting of BigDecimal and BigInteger in the web console. #1990

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

jcferretti
Copy link
Member

This change by itself does not make a difference, but together with this change on the web-client-ui repo does the trick:

cfs@erke 12:58:09 ~/dh/oss3/web-client-ui
$ git diff
diff --git a/packages/iris-grid/src/TableUtils.ts b/packages/iris-grid/src/TableUtils.ts
index cdfb3d1..b0f5e9b 100644
--- a/packages/iris-grid/src/TableUtils.ts
+++ b/packages/iris-grid/src/TableUtils.ts
@@ -294,6 +294,7 @@ class TableUtils {
       case 'java.lang.Double':
       case 'float':
       case 'java.lang.Float':
+      case 'java.math.BigDecimal':
       case TableUtils.dataType.DECIMAL:
         return TableUtils.dataType.DECIMAL;
       case 'int':
@@ -304,6 +305,7 @@ class TableUtils {
       case 'java.lang.Short':
       case 'byte':
       case 'java.lang.Byte':
+      case 'java.math.BigInteger':
       case TableUtils.dataType.INT:
         return TableUtils.dataType.INT;
       default:

Selection_195

@jcferretti jcferretti added this to the Feb 2022 milestone Feb 17, 2022
@jcferretti jcferretti self-assigned this Feb 17, 2022
@jcferretti jcferretti merged commit b8aa448 into deephaven:main Feb 17, 2022
@jcferretti jcferretti deleted the cfs-numberformat-bigdec-0 branch February 17, 2022 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
@jcferretti
Copy link
Member Author

PR for doc here (merged already): https://github.com/deephaven/deephaven.io/pull/1189

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants