Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of dependencies for faster/simplier rebuilds #1707

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

niloc132
Copy link
Member

This is an attempt to use implementation when we can over api (or compile), to better force projects to explicitly declare the dependencies they use and export. The effect of this will be fewer recompiles when not necessary, smaller classpaths for those compiles (which can make them faster), and better parallelization (due to a sparser dependency graph).

The "new" dependencies introduced in this commit were ones that were transitive before with no need to be (i.e. not part of the actual API, but exposed anyway). Some of these are negotiable, like what should the grpc-api project actually expose to downstream projects - this is just a proposal that appears to build as-is, cherry-picked from the jetty work, to make that eventual merge smaller.

Partial #1270

@niloc132
Copy link
Member Author

Some dependencies are not propagating to grpc-api flight test - in the future this will be its own project, testing by the netty and jetty server implementations separately, but should be fixed for this commit.

@devinrsmith
Copy link
Member

Happy to approve once passing tests, and continue limiting dependencies in the future, as we need to upgrade gradle sometime.

@niloc132 niloc132 merged commit 2d47153 into deephaven:main Dec 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants