Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy is missing from the required dependencies of pydeephaven #6304

Closed
jmao-denver opened this issue Oct 28, 2024 · 0 comments · Fixed by #6308
Closed

numpy is missing from the required dependencies of pydeephaven #6304

jmao-denver opened this issue Oct 28, 2024 · 0 comments · Fixed by #6308
Assignees
@jmao-denver
Labels
bug Something isn't working python-client
Milestone
0.37.0

Comments

@jmao-denver
Copy link
Contributor

The introduction of the non_unique_sentinel parameter in the unique function in agg.py module added a dependency on numpy which is missing in the packaging module (setup.py) of pydeephaven.
@jmao-denver jmao-denver added bug Something isn't working triage python-client labels Oct 28, 2024
@jmao-denver jmao-denver added this to the 0.37.0 milestone Oct 28, 2024
@jmao-denver jmao-denver self-assigned this Oct 28, 2024
@jmao-denver jmao-denver mentioned this issue Oct 29, 2024
Merged
jmao-denver added a commit that referenced this issue Oct 29, 2024
@jmao-denver
fix: Add numpy as a required dependency for py client (#6308)
640ab8f 
and clean up setup.py a bit

Fixes #6304
devinrsmith pushed a commit to devinrsmith/deephaven-core that referenced this issue Nov 21, 2024
@jmao-denver @devinrsmith
fix: Add numpy as a required dependency for py client (deephaven#6308)
6772c6f 
and clean up setup.py a bit

Fixes deephaven#6304
devinrsmith pushed a commit to devinrsmith/deephaven-core that referenced this issue Nov 21, 2024
@jmao-denver @devinrsmith
fix: Add numpy as a required dependency for py client (deephaven#6308)
42c5d42 
and clean up setup.py a bit

Fixes deephaven#6304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmao-denver jmao-denver

Labels
bug Something isn't working python-client
Projects
None yet
Milestone
0.37.0
Development

Successfully merging a pull request may close this issue.

fix: Add numpy as a required dependency for py client jmao-denver/deephaven-core
1 participant
@jmao-denver