Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticking charts in JS API are broken #6074

Closed
niloc132 opened this issue Sep 17, 2024 · 0 comments · Fixed by #6076
Closed

Ticking charts in JS API are broken #6074

niloc132 opened this issue Sep 17, 2024 · 0 comments · Fixed by #6076
Assignees
Labels
bug Something isn't working jsapi plotting
Milestone

Comments

@niloc132
Copy link
Member

Description

After the JS refactor, at least some ticking tables produce errors when displayed in charts.

This is a regression caused by #5890.

Steps to reproduce

  1. Create a ticking table with inserts as well as appends, e.g.
    from deephaven import time_table
    t = time_table("PT0.01s").update(["I=i", "J=I % 7841", "K = I % 7853", "L = J * K", "M = Math.sin(L)"]).sort("M")
  2. Using the chart builder, create a chart from this table
    Expected results

A chart should appear that gets new rows added to it

Actual results

The chart does not have updates, and there are errors in the browser console, such as

User callback ( 
function lambda() ) of type  updated  failed:  
Object { stackTrace: (39) […], detailMessage: "Index: 66, Size: 66", backingJsObject: Error, suppressedExceptions: [] }
@niloc132 niloc132 added bug Something isn't working jsapi plotting labels Sep 17, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Sep 17, 2024
@niloc132 niloc132 self-assigned this Sep 17, 2024
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 17, 2024
Only viewport subscriptions should read data (and formatting) by
position. Also fixes an error where -1 was not returned when an invalid
position was checked in a RangeSet.

Fixes deephaven#6074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jsapi plotting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant