Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze test failures from datagen fixes #4743

Closed
niloc132 opened this issue Oct 30, 2023 · 1 comment · Fixed by #4996
Closed

Analyze test failures from datagen fixes #4743

niloc132 opened this issue Oct 30, 2023 · 1 comment · Fixed by #4996
Assignees
Labels
bug Something isn't working core Core development tasks query engine test

Comments

@niloc132
Copy link
Member

niloc132 commented Oct 30, 2023

Changes made to io.deephaven.engine.testutil.generator.FloatGenerator and io.deephaven.engine.testutil.generator.DoubleGenerator which correct range issues, effectively reduce the range of possible values. This ends up failing a variety of tests (this may not be a complete list since the generation of data isn't deterministic)


io.deephaven.engine.table.impl.QueryTableAggregationTest > testTDigestIncremental FAILED
    junit.framework.ComparisonFailure at QueryTableAggregationTest.java:2832

io.deephaven.engine.table.impl.updateby.TestRollingProduct > testStaticZeroKeyTimedRev FAILED
    junit.framework.ComparisonFailure at TestRollingProduct.java:424

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingTimedFwdExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:986

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingFwdRev FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:854

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingTimedRev FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:887

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingFwd FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:798

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingRev FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:742

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingFwdExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:826

io.deephaven.engine.table.impl.updateby.TestRollingSum > testBucketedGeneralTickingRevExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingSum.java:770

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticBucketedRevExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticZeroKeyFwdExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticBucketedFwd FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticBucketedRev FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticZeroKeyRevExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticZeroKeyFwdRevWindow FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticZeroKeyTimedFwdExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:653

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticBucketedFwdExclusive FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestRollingWAvg > testStaticGroupedBucketed FAILED
    junit.framework.ComparisonFailure at TestRollingWAvg.java:548

io.deephaven.engine.table.impl.updateby.TestUpdateByGeneral > testMixedGeneralZeroKey FAILED
    junit.framework.ComparisonFailure at TestUpdateByGeneral.java:183

io.deephaven.engine.table.impl.updateby.TestUpdateByGeneral > testMixedAppendOnlyZeroKey FAILED
    junit.framework.ComparisonFailure at TestUpdateByGeneral.java:181

io.deephaven.engine.table.impl.updateby.TestUpdateByGeneral > testMixedAppendOnlyBucketed FAILED
    junit.framework.ComparisonFailure at TestUpdateByGeneral.java:181

io.deephaven.engine.table.impl.updateby.TestUpdateByGeneral > testMixedGeneralBucketed FAILED
    junit.framework.ComparisonFailure at TestUpdateByGeneral.java:183
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Initiating shutdown processing
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Starting to invoke FIRST shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Done invoking FIRST shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Starting to invoke MIDDLE shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Done invoking MIDDLE shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Starting to invoke LAST shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Done invoking LAST shutdown tasks
[Thread-14] WARN io.deephaven.util.process.ShutdownManagerImpl - Finished shutdown processing

1212 tests completed, 22 failed

A commit has been made which reduces the range of the generated data in a few places - could just as easily increase the tolerance of the tests. Some investigation should be done to verify that these reduced ranges/tolerances are appropriate.

@niloc132 niloc132 added bug Something isn't working test labels Oct 30, 2023
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Oct 30, 2023
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Oct 30, 2023
@rcaudy rcaudy added query engine core Core development tasks labels Oct 30, 2023
@rcaudy rcaudy added this to the October 2023 milestone Oct 30, 2023
@niloc132
Copy link
Member Author

from deephaven import empty_table
to = 10000
from_ = -10000
t = empty_table(10000).update("rand = Math.random()").update_view([
    "oldVal = from_ + (rand * to - from_)", 
    "okayVal = from_ + (rand * (to - from_))", 
    "newVal = (from_ / 2 + (rand * (to / 2 - from_ / 2))) * 2"
])

image

niloc132 added a commit that referenced this issue Nov 1, 2023
…4735)

Also ensures generating BigIntegers with a default range can contain
some nulls.

See #4743 for later follow-up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core development tasks query engine test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants