Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java-client loses top-level filter designation #4606

Closed
devinrsmith opened this issue Oct 5, 2023 · 1 comment · Fixed by #4607
Closed

java-client loses top-level filter designation #4606

devinrsmith opened this issue Oct 5, 2023 · 1 comment · Fixed by #4607
Assignees
Labels
bug Something isn't working java-client

Comments

@devinrsmith
Copy link
Member

When executing a filter via the java client, the top-level filters are combined into a single and-filter. This concatenation causes the resulting query to lose the special enigne parsing logic afforded to these top-level filters.

For example, when trying to execute

table.where("Sym in `WM`, `XOM`", "Size > 1")

via the java client, it currently gets mushed into the single query string

((Sym in `WM`, `XOM`) && (Size > 1))

(which is also not a valid engine string), resulting in:

Exception message         : Invalid expression ((Sym in "WM", "XOM") && (Size > 1)): [Encountered unexpected token: "\"WM\"" <STRING_LITERAL>                                                                                          
    at line 1, column 10.                                                                                                                                                                                                              
                                                                                                                                                                                                                                       
Was expecting one of:                                                                                                                                                                                                                  
                                                                                                                                                                                                                                       
    ")"                                                                                                                                                                                                                                
    ","                                                                                                                                                                                                                                
    "@"                                                                                                                                                                                                                                
    "["                                                                                                                                                                                                                                
                                                                                                                                                                                                                                       
Problem stacktrace :                                                                                                                                                                                                                   
  com.github.javaparser.GeneratedJavaParser.generateParseException(GeneratedJavaParser.java:13708)                                                                                                                                     
...                                                                                                                                
  com.github.javaparser.JavaParser.parse(JavaParser.java:123)                                                                                                                                                                          
  io.deephaven.engine.table.impl.lang.JavaExpressionParser.parseExpression(JavaExpressionParser.java:27)                                                                                                                               
  io.deephaven.engine.table.impl.lang.QueryLanguageParser.<init>(QueryLanguageParser.java:265)                                                                                                                                         
  io.deephaven.engine.table.impl.lang.QueryLanguageParser.<init>(QueryLanguageParser.java:224)                                                                                                                                         
  io.deephaven.engine.table.impl.lang.QueryLanguageParser.<init>(QueryLanguageParser.java:198)                                                                                                                                         
  io.deephaven.engine.table.impl.select.codegen.FormulaAnalyzer.getCompiledFormula(FormulaAnalyzer.java:133)                                                                                                                           
  io.deephaven.engine.table.impl.select.DhFormulaColumn.initDef(DhFormulaColumn.java:194)                                                                                                                                              
  io.deephaven.engine.table.impl.select.SwitchColumn.initDef(SwitchColumn.java:68)                                                                                                                                                     
  io.deephaven.engine.table.impl.select.analyzers.SelectAndViewAnalyzer.create(SelectAndViewAnalyzer.java:110)                                                                                                                         
  io.deephaven.engine.table.impl.select.analyzers.SelectAndViewAnalyzer.create(SelectAndViewAnalyzer.java:59)
  io.deephaven.engine.table.impl.QueryTable.validateSelect(QueryTable.java:1441)
  io.deephaven.server.table.validation.ColumnExpressionValidator.validateColumnExpressions(ColumnExpressionValidator.java:102)
  io.deephaven.server.table.validation.ColumnExpressionValidator.validateSelectFilters(ColumnExpressionValidator.java:91)
  io.deephaven.server.table.ops.UnstructuredFilterTableGrpcImpl.create(UnstructuredFilterTableGrpcImpl.java:37)
@devinrsmith devinrsmith added bug Something isn't working java-client labels Oct 5, 2023
@devinrsmith devinrsmith added this to the September 2023 milestone Oct 5, 2023
@devinrsmith devinrsmith self-assigned this Oct 5, 2023
@devinrsmith
Copy link
Member Author

A quick workaround is to use separate where invocations:

table.where("Sym in `WM`, `XOM`").where("Size > 1")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java-client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant